Skip to content

Allow configuration from .vscode/settings.json when in a Multi-root project.#6

Merged
soderlind merged 2 commits intosoderlind:masterfrom
WraithKenny:master
Jan 9, 2018
Merged

Allow configuration from .vscode/settings.json when in a Multi-root project.#6
soderlind merged 2 commits intosoderlind:masterfrom
WraithKenny:master

Conversation

@WraithKenny
Copy link
Copy Markdown
Contributor

No description provided.

@WraithKenny
Copy link
Copy Markdown
Contributor Author

The conflict is only the version number

@WraithKenny
Copy link
Copy Markdown
Contributor Author

Sorry for the white space in the diff, my code editor automatically does that.

@soderlind soderlind merged commit ee3a6db into soderlind:master Jan 9, 2018
@soderlind
Copy link
Copy Markdown
Owner

Thank you :)

@soderlind
Copy link
Copy Markdown
Owner

soderlind commented Jan 9, 2018

Found one error, if ${workspaceRoot} is used, this will fail:

        if (this.executablePath.startsWith("${workspaceRoot}") || this.executablePath.startsWith("${workspaceFolder}")) {
            this.addRootPath("${workspaceFolder}");
        }

.. I've fixed it

@WraithKenny
Copy link
Copy Markdown
Contributor Author

I don't think the code would've failed. workspaceRoot is deprecated (but still functional) and should generally be replaced with workspaceFolder.

I see how it might be desirable to support it as it was previously, as workspaceRoot will resolve to the first folder (workspaceFolders[0]) instead of the current folder, if anyone wants to rely on that (its a bit hacky behavior). Maybe leave it as an undocumented feature :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants