Allow configuration from .vscode/settings.json when in a Multi-root project.#6
Merged
soderlind merged 2 commits intosoderlind:masterfrom Jan 9, 2018
WraithKenny:master
Merged
Allow configuration from .vscode/settings.json when in a Multi-root project.#6soderlind merged 2 commits intosoderlind:masterfrom WraithKenny:master
.vscode/settings.json when in a Multi-root project.#6soderlind merged 2 commits intosoderlind:masterfrom
WraithKenny:master
Conversation
Contributor
Author
|
The conflict is only the version number |
Contributor
Author
|
Sorry for the white space in the diff, my code editor automatically does that. |
Owner
|
Thank you :) |
Owner
|
Found one error, if if (this.executablePath.startsWith("${workspaceRoot}") || this.executablePath.startsWith("${workspaceFolder}")) {
this.addRootPath("${workspaceFolder}");
}.. I've fixed it |
Contributor
Author
|
I don't think the code would've failed. I see how it might be desirable to support it as it was previously, as workspaceRoot will resolve to the first folder (workspaceFolders[0]) instead of the current folder, if anyone wants to rely on that (its a bit hacky behavior). Maybe leave it as an undocumented feature :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.