feat: show scratchpad windows in launcher #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add RunCommand function to run shell commands.
Make the command structure easier to follow by moving commands that has subcommands into subfolders.
Make the launcher configurable.
Switch to use jj to figure out the version and commit for the build info.
Add launcherOptions as a configuration. Let the user choose the options to pass to the launcher.
Validate malicious command patterns before executing the command. Add tests for command validation and run command functions.
Update the README with latest changes. Set the default launcher and launcher options if not configured.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are multiple windows on the scratchpad workspace, open a launcher (fuzzel by default) and list the available windows so the user can choose the window to bring to the current workspace.
Add RunCommand function to enable shell commands to be run.
Add validation on the command to be run, to check for malicious commands.
Add tests for command validation.
Refactoring:
If a command has sub-commands, move the commands to a sub-folder for clearer separation.
Use jj instead of git to figure out the version and commit hash during just install.