Add contiguous assignment of states as redundancy metric #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because the distribution of sizes is very skewed. To avoid the metric being influenced by this skew, we use the median instead. I'd love to use the mode here, but the sizes are too variable for that to give meaningful values.
This should help with interpretability when changing between bin sizes. Especially considering you can't have 2.5 bins (so an optimal number might not translate etc).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request will add a new metric for assessing redundant states. The metric is the median length of contiguous state assignments for each state. The reason we are using this is outlined in the updated documentation. Put simply, there's an edge case that isolation score cannot pick up, so this metric is in place to identify such edge cases and give even more information to the user.
Type of change
Checklist: