Skip to content

Conversation

@fredroy
Copy link
Contributor

@fredroy fredroy commented Jul 22, 2022

Based on

(nice to check regression for every commit)

  • Replace beginEdit/endEdit with writeAcessor
  • Remove using namespace and make it explicit with vector is used (std:: or type:: ???)
  • Remove one useless specialized function
  • Remove warnings about conversion from int to unsigned (or float??)
  • Remove one weird use of indices as float (??)
  • Change NULL to nullptr
  • use checkEventType instead of a dyn_cast
  • clean dtors
  • remove useless templatename
  • etc....

@fredroy fredroy force-pushed the various_cleanup branch 4 times, most recently from 44d96af to 32becdd Compare July 27, 2022 08:26
@epernod epernod merged commit 830b5d7 into sofa-framework:master Aug 4, 2022
@fredroy fredroy deleted the various_cleanup branch March 19, 2025 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants