Fix compilation when not using image plugin#40
Merged
hugtalbot merged 3 commits intosofa-framework:masterfrom Dec 11, 2025
Merged
Fix compilation when not using image plugin#40hugtalbot merged 3 commits intosofa-framework:masterfrom
image plugin#40hugtalbot merged 3 commits intosofa-framework:masterfrom
Conversation
hugtalbot
approved these changes
Dec 4, 2025
Contributor
|
Your proposition is good and makes sens. The only issue is that you are doing it wrong. We want anyone building upon this plugin (which will certainly never be the case but anyway) to know if it has been compiled with it or not. To do so you need to add a |
Contributor
Author
|
@bakpaul Thanks for the feedback, I agree with that and I'll make the changes. |
Contributor
Author
|
|
hugtalbot
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In cases where compiling the
CGALPluginwihtoutimageplugin support, such as thesupported-pluginsSOFA CMake presets, this plugin was not compiling anymore due to the absence of definition ofregisterMeshGenerationFromImagemethod.This PR proposes to fix this by setting a preprocessor definition when compiling with
imageplugin.