[SofaPython3/splib] Add a gentle deprecation message and info on how to find the SPLIB. #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to find the SPLIB. If someone do an import splib expecting to rely on the one in SofaPython3. This will raise an exception telling how to find it.
Contributor
|
Just by curiosity, if splib is cloned/installed/etc, will it overwrite this "placeholder" splib/_init_.py at the building stage ? |
Contributor
Author
|
It is the behavior I got (and I expect). |
guparan
added a commit
to guparan/SofaPython3
that referenced
this pull request
Sep 30, 2021
… on how to find the SPLIB. (sofa-framework#191)" This reverts commit 6257993.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In initial version of SofaPython3 there was a partial version of SPLIB that was removed.
If someone still do an import splib expecting to rely on the one in SofaPython3 it will get and error saying splib is missing.
In this PR we have added a fake splib file so importing it results in an exception indicating how to install it.