Add addObject spelling support (again)#322
Merged
alxbilger merged 2 commits intosofa-framework:masterfrom Dec 8, 2022
Merged
Conversation
damienmarchal
force-pushed
the
pr-add-difflib-support-fix
branch
from
20a1956 to
fc46102
Compare
damienmarchal
force-pushed
the
pr-add-difflib-support-fix
branch
from
fc46102 to
be841c8
Compare
damienmarchal
changed the title
alxbilger
requested changes
Dec 8, 2022
Thanks Co-authored-by: Alex Bilger <alxbilger@users.noreply.github.com>
Contributor
Author
|
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #314 but with 2.6.0 setting for the backward compatibility to old pybind11 version.
py::type was introduced at 2.6.0 so there is no need for the macro after that.
The previous merged problem was not detected before because pybind11 on sofa-jenkins is 2.6.2 while pybind11 on sofapython/github actions is 2.4.