Skip to content

Fix v23.06 ci#363

Merged
alxbilger merged 3 commits intosofa-framework:v23.06from
olivier-roussel:fix_v23.06_ci
Jul 24, 2023
Merged

Fix v23.06 ci#363
alxbilger merged 3 commits intosofa-framework:v23.06from
olivier-roussel:fix_v23.06_ci

Conversation

@olivier-roussel
Copy link
Copy Markdown
Contributor

  • Update ci.yml to run CI on the v23.06 branch (and not master)
  • Temporarily disable MacOS build as it seems down

@alxbilger
Copy link
Copy Markdown
Contributor

arf, Windows failed. Do you know why?

@alxbilger
Copy link
Copy Markdown
Contributor

Also, be aware of #358

@olivier-roussel
Copy link
Copy Markdown
Contributor Author

olivier-roussel commented Jul 24, 2023

Will require #358 to make CI / "Deploy artifacts" pass.
Is it fine to cherry pick it ?
Edit: We "crossed-fire" on this one :)

@alxbilger
Copy link
Copy Markdown
Contributor

yes cherry pick is ok here

@olivier-roussel
Copy link
Copy Markdown
Contributor Author

For the Windows build, we got a ConnectionResetError, or with more details:

ERROR   : Download of 5.12.8-0-202004051457qtwebengine-Windows-Windows_10-MSVC2017-Windows-Windows_10-X86_64.7z has error: ("Connection broken: ConnectionResetError(10054, 'An existing connection was forcibly closed by the remote host', None, 10054, None)", ConnectionResetError(10054, 'An existing connection was forcibly closed by the remote host', None, 10054, None))

Maybe shall we just restart the CI ?

The CI fails because "dev-drprasad/delete-tag-and-release@v0.2.0" no longer exists.
@olivier-roussel
Copy link
Copy Markdown
Contributor Author

Restarting the CI done the job.

@alxbilger alxbilger merged commit bc4ef0c into sofa-framework:v23.06 Jul 24, 2023
@alxbilger
Copy link
Copy Markdown
Contributor

could you also remove MacOS on master? I think you need a SofaPython3 package in the other plugins. I am not sure you can choose which branch of SofaPython3 you want in GitHub actions

@olivier-roussel
Copy link
Copy Markdown
Contributor Author

It seems to pick the same branch branch for SofaPython3 package than the plugin one (but in nightly-releases, so there might be some things to fix).
But fine, will remove MacOS from master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants