Fix rightBeforeLoadingScene method overloading#585
Merged
fredroy merged 3 commits intosofa-framework:masterfrom Mar 19, 2026
Merged
Fix rightBeforeLoadingScene method overloading#585fredroy merged 3 commits intosofa-framework:masterfrom
fredroy merged 3 commits intosofa-framework:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A code smell.
SceneLoaderListernerderives fromSceneLoader::Listener. The classSceneLoader::Listenerhas a methodrightBeforeLoadingSceneaccepting aSceneLoader*. ButSceneLoaderListernerdoes not overload it. Instead, it define another methodrightBeforeLoadingScenewith a different signature. Even if it is intentional, I did not find any call of this signature. So my guess is a wrong overriding of the base method.However, now that it's properly implemented, I don't know the effects of this call...