Support all types of mappings#593
Merged
hugtalbot merged 1 commit intosofa-framework:masterfrom Mar 12, 2026
Merged
Conversation
fredroy
requested changes
Mar 5, 2026
|
|
||
| void moduleAddMapping(py::module &m) { | ||
| declareMapping<Rigid3dTypes, Vec3dTypes>(m); | ||
| declareMapping<Vec1dTypes, Vec1dTypes>(m); |
Contributor
There was a problem hiding this comment.
Suggested change
| declareMapping<Vec1dTypes, Vec1dTypes>(m); | |
| declareMapping<Vec1Types, Vec1Types>(m); |
I just do one just to show, and you will need to modify the alias before (using sofa::defaulttype::Vec1Types blabla)
Contributor
Author
There was a problem hiding this comment.
I hesitated to do that because depending on SReal, we don't end up with the same class name for the Python class (Mapping_Vec1d_Vec2d vs Mapping_Vec1f_Vec2f). Perhaps we can think about having a more generic name such as Mapping_Vec1_Vec2...
Contributor
Author
There was a problem hiding this comment.
The force field bindings also support only double
fredroy
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is all the types defined in
Mapping.cpp