Skip to content

Acquire gil for the full scope of the lifetime returned matrix #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fredroy merged 1 commit into from
Apr 23, 2026
Merged

Acquire gil for the full scope of the lifetime returned matrix #609

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion bindings/Sofa/src/SofaPython3/Sofa/Core/Binding_ForceField.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,6 @@ namespace sofapython3
template<class TDOFType>
py::object ForceField_Trampoline<TDOFType>::_addKToMatrix(const MechanicalParams* mparams, int nIndices, int nDofs)
{
PythonEnvironment::gil acquire;

py::dict mp = py::dict("time"_a=getContext()->getTime(),
"mFactor"_a=mparams->mFactor(),
Expand All @@ -136,6 +135,8 @@ namespace sofapython3
template<class TDOFType>
void ForceField_Trampoline<TDOFType>::addKToMatrix(const MechanicalParams* mparams, const MultiMatrixAccessor* dfId)
{
PythonEnvironment::gil acquire;

MultiMatrixAccessor::MatrixRef mref = dfId->getMatrix(this->mstate);
sofa::linearalgebra::BaseMatrix* mat = mref.matrix;

Expand Down
Loading