Skip to content

Extract inverse values builders into services#123

Merged
HypeMC merged 1 commit intosofascore:2.xfrom
HypeMC:extract-inverse-values-builders-into-services
Dec 16, 2025
Merged

Extract inverse values builders into services#123
HypeMC merged 1 commit intosofascore:2.xfrom
HypeMC:extract-inverse-values-builders-into-services

Conversation

@HypeMC
Copy link
Copy Markdown
Member

@HypeMC HypeMC commented Dec 15, 2025

Needed for #112.

@HypeMC HypeMC requested a review from Brajk19 December 15, 2025 03:36
@HypeMC HypeMC self-assigned this Dec 15, 2025
@HypeMC HypeMC force-pushed the extract-inverse-values-builders-into-services branch from 99a9d8f to aa5a225 Compare December 15, 2025 03:56
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.25%. Comparing base (63c91dd) to head (a305692).
⚠️ Report is 1 commits behind head on 2.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x     #123      +/-   ##
============================================
+ Coverage     96.92%   97.25%   +0.33%     
- Complexity      484      489       +5     
============================================
  Files            62       65       +3     
  Lines          1364     1385      +21     
============================================
+ Hits           1322     1347      +25     
+ Misses           42       38       -4     
Flag Coverage Δ
8.1 96.38% <100.00%> (-0.02%) ⬇️
8.2 97.18% <100.00%> (+0.77%) ⬆️
8.3 96.89% <100.00%> (+0.04%) ⬆️
8.4 96.96% <100.00%> (+0.11%) ⬆️
8.5 96.45% <100.00%> (-0.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HypeMC HypeMC force-pushed the extract-inverse-values-builders-into-services branch 2 times, most recently from ab0ddfd to 1ac87a7 Compare December 15, 2025 06:40
@HypeMC HypeMC mentioned this pull request Dec 15, 2025
1 task
@HypeMC HypeMC force-pushed the extract-inverse-values-builders-into-services branch from 1ac87a7 to 5c846c2 Compare December 15, 2025 07:44
Comment thread config/services.php
Comment thread config/services.php Outdated
@HypeMC HypeMC force-pushed the extract-inverse-values-builders-into-services branch from 5c846c2 to 49e2e41 Compare December 15, 2025 19:14
@HypeMC HypeMC changed the base branch from 1.x to 2.x December 15, 2025 19:17
Brajk19
Brajk19 previously approved these changes Dec 15, 2025
@HypeMC HypeMC force-pushed the extract-inverse-values-builders-into-services branch from 49e2e41 to a305692 Compare December 16, 2025 09:34
@HypeMC HypeMC merged commit bc2361c into sofascore:2.x Dec 16, 2025
27 of 28 checks passed
@HypeMC HypeMC deleted the extract-inverse-values-builders-into-services branch December 16, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants