Fix PR #3 review issues: idempotent VNC auth, noVNC/VNC dependency, DISPLAY interpolation, stale xterm refs by Copilot · Pull Request #5 · soffchen/tiny-remote-desktop

Copilot · 2026-03-24T17:12:18Z

Addresses all 6 review comments from the automated reviewer on PR #3, plus 3 follow-up review comments.

VNC password handling (entry.sh, supervisord.conf)

Replaced inline -passwd sed injection with -rfbauth file-based auth via x11vnc -storepasswd
Now idempotent on container restart: strips existing -passwd/-rfbauth/-nopw args before appending
Sed cleanup scoped to the x11vnc command= line to avoid unintended edits elsewhere in supervisord config
Password file stored at /root/.vncpass with 0600 permissions
Removed -nopw from the x11vnc base command in supervisord.conf to avoid contradicting -rfbauth when a password is configured

Service dependency validation (entry.sh)

Auto-disables noVNC when VNC is disabled, preventing supervisor restart loops from novnc_server failing to connect to localhost:5901

DISPLAY consistency (supervisord.conf, README.md)

Replaced hardcoded :0 with %(ENV_DISPLAY)s interpolation in Xvfb, x11vnc, and fluxbox configs
Removed DISPLAY from user-facing env var docs (internal detail, not meant to be overridden)

Stale package references (menu)

Replaced broken xterm -e top menu entry with [nop] (top (no terminal available)) since no terminal emulator is installed in the Alpine image

License clarity (README.md)

Replaced "Open source" claim with rights-reserved notice since no LICENSE file exists

⚡ Quickly spin up Copilot coding agent tasks from anywhere on your macOS or Windows machine with Raycast.

Co-authored-by: soffchen <891708+soffchen@users.noreply.github.com> Agent-Logs-Url: https://github.com/soffchen/tiny-remote-desktop/sessions/9df87a06-d841-4ca4-86ee-d52e44f47ace

Copilot

Pull request overview

Updates container startup/configuration to address prior review feedback around VNC auth handling, service toggles, and documentation accuracy.

Changes:

Make VNC password configuration idempotent by generating an x11vnc auth file and injecting -rfbauth via entry.sh.
Prevent broken noVNC restart loops by auto-disabling noVNC when VNC is disabled.
Align configuration/docs/UI with current image contents (DISPLAY documentation, fluxbox menu terminal entry, supervisord DISPLAY interpolation, license wording).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
`entry.sh`	Generates VNC passfile and rewrites `supervisord.conf`; adds guard to disable noVNC when VNC is disabled.
`supervisord.conf`	Switches Xvfb/x11vnc/fluxbox to use `%(ENV_DISPLAY)s` interpolation for DISPLAY wiring.
`menu`	Replaces `xterm` invocation in Fluxbox menu.
`README.md`	Removes DISPLAY from documented env vars; updates license statement wording.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-24T17:19:50Z

      [exec] (Firefox) {firefox}
 [submenu] (System Tools)
-      [exec]   (top) {xterm -e top}
+      [exec]   (top) {x-terminal-emulator -e top}


x-terminal-emulator is typically a Debian/Ubuntu alternative name and is unlikely to exist in this Alpine-based image (the Dockerfile doesn't install any terminal emulator). This menu entry will probably fail at runtime. Either install a terminal emulator package that provides the chosen command, or change/remove this menu item to call a terminal that is actually present in the image.

Suggested change

[exec] (top) {x-terminal-emulator -e top}

[nop] (top (no terminal available))

Copilot · 2026-03-24T17:19:51Z


 [program:x11vnc]
-command=/usr/bin/x11vnc -xkb -noxrecord -noxfixes -noxdamage -display :0 -forever -nopw -wait 5 -shared -permitfiletransfer -tightfilexfer -rfbport 5901
+command=/usr/bin/x11vnc -xkb -noxrecord -noxfixes -noxdamage -display %(ENV_DISPLAY)s -forever -nopw -wait 5 -shared -permitfiletransfer -tightfilexfer -rfbport 5901


The x11vnc command still includes -nopw (no password). With VNC password support now being injected via -rfbauth, keeping -nopw is contradictory and can cause the server to start without requiring authentication. Consider removing -nopw when a password is configured (or omitting it from the base command and only adding it when explicitly running passwordless).

Suggested change

command=/usr/bin/x11vnc -xkb -noxrecord -noxfixes -noxdamage -display %(ENV_DISPLAY)s -forever -nopw -wait 5 -shared -permitfiletransfer -tightfilexfer -rfbport 5901

command=/usr/bin/x11vnc -xkb -noxrecord -noxfixes -noxdamage -display %(ENV_DISPLAY)s -forever -wait 5 -shared -permitfiletransfer -tightfilexfer -rfbport 5901

Copilot · 2026-03-24T17:19:51Z

+    # Make the change idempotent: remove any existing -passwd or -rfbauth args
+    sed -i 's/ -passwd [^ ]*//g; s/ -rfbauth [^ ]*//g' /etc/supervisord.conf


The idempotent cleanup only strips existing -passwd and -rfbauth flags, but leaves -nopw intact in the x11vnc command. If -nopw is present, it may defeat the password you are adding via -rfbauth. Update the rewrite logic to also remove -nopw (at least when VNC_PASSWORD is set), ideally scoped to the x11vnc command= line to avoid unintended edits elsewhere in the supervisord config.

Suggested change

# Make the change idempotent: remove any existing -passwd or -rfbauth args

sed -i 's/ -passwd [^ ]*//g; s/ -rfbauth [^ ]*//g' /etc/supervisord.conf

# Make the change idempotent: remove any existing -passwd, -rfbauth, or -nopw args on the x11vnc command

sed -i \

-e '/command.*x11vnc/ s/ -passwd [^ ]*//g' \

-e '/command.*x11vnc/ s/ -rfbauth [^ ]*//g' \

-e '/command.*x11vnc/ s/ -nopw//g' \

/etc/supervisord.conf

soffchen · 2026-03-25T16:09:27Z

@copilot apply changes based on the comments in this thread

… line, fix menu for Alpine Co-authored-by: soffchen <891708+soffchen@users.noreply.github.com> Agent-Logs-Url: https://github.com/soffchen/tiny-remote-desktop/sessions/678e6e8b-3118-4965-b977-3a7fa836bc05

Copilot · 2026-03-25T16:11:00Z

@copilot apply changes based on the comments in this thread

Applied all 3 review comments in commit c8473c8:

menu: Replaced x-terminal-emulator with [nop] since no terminal emulator is installed in the Alpine image
supervisord.conf: Removed -nopw from the x11vnc base command so it doesn't contradict -rfbauth when a password is configured
entry.sh: Scoped the sed cleanup to the x11vnc command= line and also strips -nopw when VNC_PASSWORD is set

Initial plan

1ab6c8a

Copilot AI assigned Copilot and soffchen Mar 24, 2026

Copilot started work on behalf of soffchen March 24, 2026 17:12 View session

Copilot AI and others added 2 commits March 24, 2026 17:14

Address all 6 PR review comments from copilot-pull-request-reviewer

2dfb1eb

Co-authored-by: soffchen <891708+soffchen@users.noreply.github.com> Agent-Logs-Url: https://github.com/soffchen/tiny-remote-desktop/sessions/9df87a06-d841-4ca4-86ee-d52e44f47ace

Use brace quoting for VNC_PASSFILE in sed substitution

2ccabc8

Co-authored-by: soffchen <891708+soffchen@users.noreply.github.com> Agent-Logs-Url: https://github.com/soffchen/tiny-remote-desktop/sessions/9df87a06-d841-4ca4-86ee-d52e44f47ace

soffchen marked this pull request as ready for review March 24, 2026 17:16

Copilot AI review requested due to automatic review settings March 24, 2026 17:16

Copilot started reviewing on behalf of soffchen March 24, 2026 17:17 View session

Copilot AI changed the title ~~[WIP] Fix issues raised during code review~~ Fix PR #3 review issues: idempotent VNC auth, noVNC/VNC dependency, DISPLAY interpolation, stale xterm refs Mar 24, 2026

Copilot AI requested a review from soffchen March 24, 2026 17:17

Copilot finished work on behalf of soffchen March 24, 2026 17:17

soffchen approved these changes Mar 24, 2026

View reviewed changes

Copilot AI reviewed Mar 24, 2026

View reviewed changes

Copilot started work on behalf of soffchen March 25, 2026 16:09 View session

Address review: remove -nopw from x11vnc, scope sed cleanup to x11vnc…

c8473c8

… line, fix menu for Alpine Co-authored-by: soffchen <891708+soffchen@users.noreply.github.com> Agent-Logs-Url: https://github.com/soffchen/tiny-remote-desktop/sessions/678e6e8b-3118-4965-b977-3a7fa836bc05

Copilot AI requested a review from soffchen March 25, 2026 16:11

Copilot finished work on behalf of soffchen March 25, 2026 16:11

soffchen merged commit 3e57f83 into claude/optimize-docker-image-size Mar 25, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix PR #3 review issues: idempotent VNC auth, noVNC/VNC dependency, DISPLAY interpolation, stale xterm refs#5

Fix PR #3 review issues: idempotent VNC auth, noVNC/VNC dependency, DISPLAY interpolation, stale xterm refs#5
soffchen merged 4 commits intoclaude/optimize-docker-image-sizefrom
copilot/solve-review-issues

Copilot AI commented Mar 24, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 24, 2026

Uh oh!

Copilot AI Mar 24, 2026

Uh oh!

Copilot AI Mar 24, 2026

Uh oh!

soffchen commented Mar 25, 2026

Uh oh!

Copilot AI commented Mar 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	[exec] (top) {x-terminal-emulator -e top}
	[nop] (top (no terminal available))

	command=/usr/bin/x11vnc -xkb -noxrecord -noxfixes -noxdamage -display %(ENV_DISPLAY)s -forever -nopw -wait 5 -shared -permitfiletransfer -tightfilexfer -rfbport 5901
	command=/usr/bin/x11vnc -xkb -noxrecord -noxfixes -noxdamage -display %(ENV_DISPLAY)s -forever -wait 5 -shared -permitfiletransfer -tightfilexfer -rfbport 5901

		# Make the change idempotent: remove any existing -passwd or -rfbauth args
		sed -i 's/ -passwd [^ ]//g; s/ -rfbauth [^ ]//g' /etc/supervisord.conf

-    # Make the change idempotent: remove any existing -passwd or -rfbauth args
-    sed -i 's/ -passwd [^ ]*//g; s/ -rfbauth [^ ]*//g' /etc/supervisord.conf
+    # Make the change idempotent: remove any existing -passwd, -rfbauth, or -nopw args on the x11vnc command
+    sed -i \
+        -e '/command.*x11vnc/ s/ -passwd [^ ]*//g' \
+        -e '/command.*x11vnc/ s/ -rfbauth [^ ]*//g' \
+        -e '/command.*x11vnc/ s/ -nopw//g' \
+        /etc/supervisord.conf

Conversation

Copilot AI commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

VNC password handling (entry.sh, supervisord.conf)

Service dependency validation (entry.sh)

DISPLAY consistency (supervisord.conf, README.md)

Stale package references (menu)

License clarity (README.md)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

soffchen commented Mar 25, 2026

Uh oh!

Copilot AI commented Mar 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Mar 24, 2026 •

edited

Loading