fix(validate): skip gcp-gce revalidation (composite vs component SKU mismatch)#65
Merged
fix(validate): skip gcp-gce revalidation (composite vs component SKU mismatch)#65
Conversation
Add SKIP_REVALIDATION dict in pipeline/validate/driver.py and short-circuit those shards with exit="skipped" in the report. Listed shards return 0 so the data-validate workflow closes any open drift issue. Initial entry: gcp-gce. Ingest (pipeline/ingest/gcp_gce.py) synthesizes per-machine totals from per-vCPU + per-GiB component prices, while the validator reads the raw component unitPrice. The two are not comparable without re-doing the ingest math, producing 20/20 false-positive drift records on every run. Closes #62.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Follow-up
A proper fix is a validation hint sidecar (ingest writes `expected_upstream_amount` per SKU; validator just compares those). Tracking issue to file once this lands.