Fix frame number generation in pyav_reader._gen_frames
#370
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyav_reader._gen_framessometimes yields frame objects with incorrect frame numbers due to incorrect rounding.Fixed by using
roundrather thanint.This has resulted in
PyAVTimedReader.get_framereturning frame objects whoseframe_nofield has a different frame than the value passed toget_frame.I was able to confirm this on a video file and verify that
PyAVTimedReaderandPyAVIndexedReaderreturn different frames when randomly seeking. Furthermore, converting the video to a sequence of PNGs using ffmpeg and reading those agrees withPyAVIndexedReaderbut notPyAVTimedReader. This fix addresses this, resulting inPyAVTimedReaderreturning frame consistency with the others.I may be able to release the video file for testing, but will have to check.