Fix warnings from .buildbot.sh #606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This might be because |
Collaborator
Author
|
That seems like a likely possibility as I haven't update my local rust compiler for a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm still slightly confused about the warnings this fixes,
They don't seem to appear with clippy, or cargo build/test. But do appear when I run
.buildbot.sh.I haven't figured out what the difference between that and the default builds is though.
I'm also not exactly sure what is happening with the
#[cfg_attr(test, allow(dead_code))].This field is used in
#[cfg(test)], but I believe that the tests it is used in might be#[cfg(...)]out underwasmleading to the dead code warning on some platforms.