Fix copy/paste error in setting up DEFAULT_LEX_FLAGS.case_insensitive.#636
Merged
ltratt merged 1 commit intosoftdevteam:masterfrom May 3, 2026
Merged
Conversation
This was accidentally defaulting to the default value for `allow_wholeline_comments`. This shouldn't have any effect, because `DEFAULT_LEX_FLAGS.allow_wholeline_comments` defaults to a different value `Some(false)` vs `None`. The `None` value sets it use the regex default value which is `false`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was accidentally defaulting to the default value for
allow_wholeline_comments. This shouldn't have any effect, becauseDEFAULT_LEX_FLAGS.allow_wholeline_commentsdefaults to a different valueSome(false)vsNone.The
Nonevalue sets it use the regex default value which isfalse.