Skip to content

Conversation

@jacob-hughes
Copy link
Contributor

No description provided.

softdev.bib Outdated
@inproceedings{barany2014python,
author = {Barany, Gerg\"{o}},
title = {Python Interpreter Performance Deconstructed},
booktitle = {Dynamic Languages and Applications},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

booktitle = {DYLA} (and remove series).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok done.

month = Jun,
pages = {5:1--5:9},
publisher = {ACM},
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does 5: refer to?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. Truth be told I copied this from the bibtex citation notes in google scholar.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we remove the pages key then.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

softdev.bib Outdated
}
@book{gudeman1995representing,
title={Representing type information in dynamically typed languages},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing spaces around =.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@jacob-hughes
Copy link
Contributor Author

Pushed review fixes.

@ltratt
Copy link
Member

ltratt commented Aug 15, 2018

Before I ask you to squash, do either of these have DOIs? It's nice, when possible, to add a doi field (but not everything has a DOI).

@jacob-hughes
Copy link
Contributor Author

I could only find a doi for the Barany paper which I've now included.

@ltratt
Copy link
Member

ltratt commented Aug 15, 2018

Looks good. Please squash.

@jacob-hughes jacob-hughes force-pushed the pointer_tagging_and_cpython_papers branch from 8fd81a1 to 5d50308 Compare August 15, 2018 16:24
@jacob-hughes
Copy link
Contributor Author

Squashed!

@ltratt ltratt merged commit 20ef0c5 into master Aug 15, 2018
@ltratt ltratt deleted the pointer_tagging_and_cpython_papers branch August 15, 2018 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants