Add conservative stack scanning bug found in Chromium #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacob-hughes
commented
Mar 2, 2023
softdev.bib
Outdated
| } | ||
| @misc{chromium20cssbug, | ||
| title = {Octane benchmark suite}, |
Contributor
Author
There was a problem hiding this comment.
Ugh, copy paste bug. I'll push a fix
Contributor
Author
There was a problem hiding this comment.
Actually, I'm a little unsure what to call this. Can I use the lengthy title of the bug report?
"base::Optional when compiled with clang leads to memory layout that is incompatible with conservative stack scanning"
Member
There was a problem hiding this comment.
Good question. Let's try that as the title and see how we feel in a day or so!
Member
|
Please squash. |
jacob-hughes
force-pushed
the
add_chromium_css_bug
branch
from
087bbfe to
ae982d7
Compare
Contributor
Author
|
Squashed |
Member
|
bors r+ |
Contributor
|
Build failed: |
Contributor
Author
|
Fixed: 8454058 |
Member
|
Please squash. |
jacob-hughes
force-pushed
the
add_chromium_css_bug
branch
from
8454058 to
921357c
Compare
Contributor
Author
|
Squashed |
Member
|
bors r+ |
Contributor
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.