Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/main/java/com/softlayer/api/Maskable.java
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,7 @@ public interface Maskable {

/** Set the mask to a string, formatted according to http://sldn.softlayer.com/article/Object-Masks */
public void setMask(String mask);

/** Removes the mask from the service */
public void clearMask();
}
7 changes: 7 additions & 0 deletions src/main/java/com/softlayer/api/RestApiClient.java
Original file line number Diff line number Diff line change
Expand Up @@ -445,6 +445,13 @@ public Object invoke(Object proxy, Method method, Object[] args) throws Throwabl
mask = (Mask) args[0];
maskString = null;
return null;
} else if ("setMask".equals(method.getName()) && args != null
&& args.length == 1 && args[0] == null) {
throw new IllegalArgumentException("Cannot set null mask. Use clearMask to clear");
} else if ("clearMask".equals(method.getName())) {
mask = null;
maskString = null;
return null;
} else if ("setResultLimit".equals(method.getName()) &&
method.getDeclaringClass() == ResultLimitable.class) {
resultLimit = (ResultLimit) args[0];
Expand Down
18 changes: 17 additions & 1 deletion src/test/java/com/softlayer/api/RestApiClientTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,24 @@ public void onSuccess(String value) {
assertTrue(http.invokeAsyncCallbackCalled);
assertTrue(successCalled.get());
}

@Test(expected = IllegalArgumentException.class)
public void testMaskMustNotBeNull() {
RestApiClient client = new RestApiClient("http://example.com/");
TestEntity.Service service = TestEntity.service(client);
service.setMask((Mask) null);
}

@Test
public void testMaskRemoval() {
RestApiClient client = new RestApiClient("http://example.com/");
TestEntity.Service service = TestEntity.service(client);
service.withMask().baz();
assertEquals("baz", service.withMask().toString());
service.clearMask();
assertEquals("", service.withMask().toString());
}

@Test
public void testNormalObjectMethodsOnService() {
RestApiClient client = new RestApiClient("http://example.com/");
Expand All @@ -439,6 +456,5 @@ public void testNormalObjectMethodsOnService() {
assertTrue(Proxy.isProxyClass(service.getClass()));
assertEquals(service.hashCode(), service.hashCode());
assertTrue(service.equals(service));

}
}