Skip to content

Fix ticket upload to be able to run with rest and xmlrpc endpoint. #1267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix ticket upload to be able to run with rest and xmlrpc endpoint. #1267

wants to merge 1 commit into from

Conversation

@FernandoOjeda
Copy link
Contributor

@FernandoOjeda FernandoOjeda commented Apr 29, 2020

Fix ticket upload to be able to run with rest and xmlrpc endpoint #1266.

@FernandoOjeda FernandoOjeda self-assigned this Apr 29, 2020
@allmightyspiff
Copy link
Member

allmightyspiff commented Apr 30, 2020

After testing this a bit, looks like there were a few problems with this solution.

  1. It breaks the XMLRPC call because the XMLRPC type will be instead of , and I guess the API doesn't deal with that. The files I uploaded with XML were all broken.
  2. Doesn't really fix any other instances that might pop up of json not being able to encode byte strings.

I added a custom JSON encoder to the transports in #1269 that should fix this.

Thanks for taking a look at this so quickly though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@allmightyspiff allmightyspiff Awaiting requested review from allmightyspiff

Assignees

@FernandoOjeda FernandoOjeda

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FernandoOjeda @allmightyspiff