slcli hw create updates
#1296
Merged
slcli hw create updates
#1296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…primarily instead of doing price lookups on its own. Added option to specify a particular networking keyname instead of just a speed
ATGE
approved these changes
Jul 14, 2020
Contributor
ATGE
left a comment
ATGE
left a comment
There was a problem hiding this comment.
it works as expected. so LGTM.
note: OS_CENTOS_6_X_32_BIT, OS_FREEBSD_10_X_32_BIT currently are showed by using slcli hw create-options, so if these items are used in order to create a server an SoftLayerAPIError(500): CentOS 6.x (32 bit) is not available as of 08/31/2016 (Item #(3904). is retrieved. I am not sure if skipping old items is possible in slcli hw create-options, but I think would be a nice feature.
FernandoOjeda
approved these changes
Jul 14, 2020
Contributor
FernandoOjeda
left a comment
FernandoOjeda
left a comment
There was a problem hiding this comment.
It looks good for me, it is working fine.
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added networking options to
slcli hw create-optionsRefactored
slcli hw createto use the ordering managerAdded
--networkoption toslcli hw createfor more granular network choices.deprecated
--port-speedand--no-public. They still work for now, but will be removed in a future release.