Skip to content

Conversation

@ATGE
Copy link
Contributor

@ATGE ATGE commented Sep 3, 2020

No description provided.

@allmightyspiff allmightyspiff self-requested a review September 10, 2020 18:34
@allmightyspiff allmightyspiff added the Ordering Anything related to ordering label Sep 10, 2020
@allmightyspiff allmightyspiff linked an issue Sep 10, 2020 that may be closed by this pull request
Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but get_billing_item_from_invoice needs to pull in the order->user information. Otherwise everything will show up as ordered by IBM.

@allmightyspiff
Copy link
Member

TESTING

$ ./slcli --format=table  -v account item-detail 1677911496
Calling: SoftLayer_Billing_Item::getObject(id=1677911496, mask='mask[ orderItem[id,order[id,userRecord[id,email,displayName,userStatus]]], nextInvoiceTotalRecurringAmount, location, hourlyFlag, children ]', filter='None', args=(), limit=None, offset=None))
Calling: SoftLayer_Billing_Invoice_Item::getBillingItem(id=1677911496, mask='', filter='None', args=(), limit=None, offset=None))
:...............................................:
:           1 x 2.0 GHz or higher Core          :
:..................:............................:
:       Key        :           Value            :
:..................:............................:
:    createDate    :         2020-04-07         :
:  cycleStartDate  :         2020-09-03         :
: cancellationDate :            None            :
:   description    : 1 x 2.0 GHz or higher Core :
:       FQDN       :    activedirectory.None    :
:   recurringFee   :             0              :
:    Ordered By    :            IBM             :
:      Notes       :            None            :
:     Location     :            None            :
:..................:............................:

updated item-detail table alignment
@allmightyspiff
Copy link
Member

Changes look good, thanks.
Not sure why analysis started failing, but i'll fix that in #1347 and then merge this.

not sure why, but using `table.align` with a KeyValueTable causes a whole bunch of pylint errors.... not really sure why KeyValueTable is a thing anymore.
@allmightyspiff allmightyspiff merged commit 1ed83f4 into softlayer:master Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ordering Anything related to ordering

Projects

None yet

Development

Successfully merging this pull request may close these issues.

account item-detail should accept an Invoice_Item id as well

2 participants