Add authorize block, file and portable storage to a vs. #1442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caberos
reviewed
Mar 22, 2021
| """ | ||
| disk_id = portable_id | ||
| result = self.client.call('SoftLayer_Virtual_Guest', 'attachDiskImage', | ||
| disk_id, id=vs_id) |
Contributor
There was a problem hiding this comment.
result = self.client.call('SoftLayer_Virtual_Guest', 'attachDiskImage', portable_id, id=vs_id)
is not better this?
Member
There was a problem hiding this comment.
I likely would have written self.client.call('SoftLayer_Virtual_Guest', 'attachDiskImage', portable_id, id=vs_id) as I think it looks better, taking up less lines.
But there are plenty of cases in the code that would break the call up like this due to line length, so this pattern of breaking up the call into 2 lines after the method is fine too.
Its not something I feel strongly enough about to make you change though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add authorize block, file and portable storage to a vs #1440.