new feature licenses create-options #1508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ATGE
reviewed
Jun 18, 2021
Contributor
ATGE
left a comment
ATGE
left a comment
There was a problem hiding this comment.
Currently looks like just displays the VMware license options, so I'm not sure if should be displayed Control Pane licenses too.
Also, there is a new manager module too: LicensesManager, please, add a unit test for that.
Contributor
FernandoOjeda
left a comment
FernandoOjeda
left a comment
There was a problem hiding this comment.
Do not forget to add unit test for the licenses managers module.
This was
linked to
issues
Jun 23, 2021
Member
|
@caberos Looks like there are some conflicts with your other branch, would your mind resolving those, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1507