Add File & Block replication commands and output#752
Merged
sudorandom merged 2 commits intosoftlayer:masterfrom Aug 18, 2016
kyubifire:replication
Merged
Add File & Block replication commands and output#752sudorandom merged 2 commits intosoftlayer:masterfrom kyubifire:replication
sudorandom merged 2 commits intosoftlayer:masterfrom
kyubifire:replication
Conversation
Code developed collaboratively by:
ccorales95 Cristina Corales <ccorales95@gmail.com>
kyubifire Nilo Lisboa <nilo_bl@hotmail.com>
VuKevin Kevin Vu <VuKevin@icloud.com>
dpickle2 David Pickle <dpickle29@gmail.com>
* Add support for ordering replicant volumes [Block & File]
* Add support for replicant failover & failback [Block & File]
* Add additional output for commands:
Add replicant info to volume-detail output [Block & File]
Show replicant volumes in volume-list output [Block & File]
| replicant_id | ||
| ) | ||
|
|
||
| if success: |
Contributor
There was a problem hiding this comment.
If success is False, shouldn't we return some kind of error message to the user? I'm not sure what conditions False would be returned over returning an exception.
* Add checks for failure in failover and failback commands; updated unit tests accordingly * Update of CONTEXT_SETTINGS assignments to use dict syntax * Utilize utils.lookup() function for os_type lookup; updated use of optional arguments for order_replicant_volume() functions and adjusted unit tests accordingly * snapshot-create crashed when a volume was failed over to its replicant (API returned an empty array); updated logic for command line output to prevent crashing and adjusted unit tests accordingly
Author
|
Thank you for your feedback! I have addressed the items you mentioned above. Please let me know if I have missed anything else. [The failover/failback commands resulted in exceptions raised by the SL API for us, but I have added else clauses to each of these commands to address the possibility of False being returned by the API.] [Thank you for pointing out the use of default values for arguments. I have updated the order_replicant_volume() functions in both File and Block managers to make 'tier' and 'os_type' optional with default values.] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several new commands and updates
to CLI output for supporting File and Block volume replication.
Code developed collaboratively by:
ccorales95 Cristina Corales ccorales95@gmail.com
kyubifire Nilo Lisboa nilo_bl@hotmail.com
VuKevin Kevin Vu VuKevin@icloud.com
dpickle2 David Pickle dpickle29@gmail.com
Add replicant info to volume-detail output [Block & File]
Show replicant volumes in volume-list output [Block & File]