CLI: Makes the price shown more accurate for virtual and hardware detail #763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incorporates the child prices into the price for virtual and hardware detail. This impacts: `slcli virtual detail [ID] --price` `slcli hardware detail [ID] --price` It also adjusts the default masks for detailing hardware and virtual instances.
Contributor
Author
|
cc: @imacdonald-cb |
|
Let me know if you want me to do some additional testing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporates the child prices into the price for virtual and hardware detail.
This impacts:
slcli virtual detail [ID] --priceslcli hardware detail [ID] --priceIt also adjusts the default masks for detailing hardware and virtual instances.
Side note: I am on the edge of removing this feature now and coming back to it later with more validation. The biggest issue that I have testing this is that I don't have a normal account and it makes testing parts of the API that have prices harder.
Resolves #749