STORAUTO-62 support for setting LUN ID on block volumes #840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if 'value' in res and lun_id == res['value']: | ||
| click.echo( | ||
| 'Block volume with id %s is reporting LUN ID %s' % (res['volumeId'], res['value'])) | ||
| else: |
Member
There was a problem hiding this comment.
how does createOrUpdateLunId report errors?
if it throws an exception, this else could be removed
if it returns false this is fine, but if it returns a message, that message should be displayed.
Author
There was a problem hiding this comment.
There is a bug that returns null when the underlying property does not exist before the method is called. I am told that is addressed in another issue.
Member
|
@causton81 looks like my change in #841 is causing a merge conflict with this pull request. When you get a chance can you update your changes to include mine to resolve this conflict. Thanks. |
causton81
force-pushed
the
feature/STORAUTO-62
branch
from
eb645d8 to
74c49ea
Compare
Author
|
@allmightyspiff , FBLOCK-3 was deployed and this should be good to merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on FBLOCK-3 being released, but I would like to address any comments in the meantime so it can be ready to go when FBLOCK-3 is released.