resource metadata update #879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
this should be fixed in the METADATA_MAPPING list, not the in call itself. I don't like the idea of appending a fixed string that can't be changed to a function call like this though. |
Contributor
Author
|
all the functions in http://sldn.softlayer.com/reference/services/SoftLayer_Resource_Metadata are getXXX calls |
allmightyspiff
approved these changes
Sep 28, 2017
Member
allmightyspiff
left a comment
allmightyspiff
left a comment
There was a problem hiding this comment.
Thanks for the changes, this looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eg: need to call as getDomain, not Domain.