Make rand and log optional#3
Merged
softprops merged 1 commit intosoftprops:masterfrom May 30, 2020
Zireael-N:optional_deps
Merged
Make rand and log optional#3softprops merged 1 commit intosoftprops:masterfrom Zireael-N:optional_deps
rand and log optional#3softprops merged 1 commit intosoftprops:masterfrom
Zireael-N:optional_deps
Conversation
Owner
|
good call @Zireael-N . also thanks for fixing my typos! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It feels like these should be opt-out.
If a user doesn't need jitter or doesn't care about logging, they might want to cut down the binary size a little bit.