Make Unix socket support optional#92
Merged
softprops merged 2 commits intosoftprops:masterfrom Sep 29, 2018
fkrull:hyperlocal-optional
Merged
Make Unix socket support optional#92softprops merged 2 commits intosoftprops:masterfrom fkrull:hyperlocal-optional
softprops merged 2 commits intosoftprops:masterfrom
fkrull:hyperlocal-optional
Conversation
By making Unix sockets optional, hyperlocal becomes optional as well, which means shiplift builds on Windows.
softprops
requested changes
Sep 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And by making that optional, the hyperlocal dependency can be made optional as well (= hidden behind the "unix-socket" feature). And without the hyperlocal dependency, the project can be used on Windows; obviously only over HTTP(S).