refactor(server): log game leave #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xeruf
force-pushed
the
fix/cancelrequest
branch
from
d4a1dd1 to
d648483
Compare
xeruf
force-pushed
the
fix/cancelrequest
branch
from
d648483 to
1a23c22
Compare
# Conflicts: # server/test/sc/protocol/requests/RequestTest.kt # socha-sdk/src/framework/sc/shared/WelcomeMessage.java # socha-sdk/src/server-api/sc/protocol/requests/CancelRequest.java # socha-sdk/src/server-api/sc/protocol/responses/LeftGameEvent.java # socha-sdk/src/server-api/sc/protocol/responses/ProtocolErrorMessage.java
…nf/socha into fix/cancelrequest
xeruf
force-pushed
the
master
branch
2 times, most recently
from
e4240d9 to
040b96b
Compare
xeruf
force-pushed
the
fix/cancelrequest
branch
from
9d05922 to
62b2f06
Compare
xeruf
force-pushed
the
fix/cancelrequest
branch
from
62b2f06 to
f2f8ae2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I was working to fix improve the CancelRequest, I don't know how this code ended up idling around for so long on my laptop. I'll look into it when we have more time.