feat(plugin): refactor some and make some logic methods public again #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anarchuser
force-pushed
the
refactor/move-validation
branch
2 times, most recently
from
60fbcc2 to
883ad6b
Compare
In turn, refactor them a bit to pass fields as parameters, instead of raw coordinates and colors
One can choose to have them throw as before, or return a `MoveMistake` enum which allows for switching of the specific issue in question.
anarchuser
force-pushed
the
refactor/move-validation
branch
from
fe63a47 to
e5baeac
Compare
SKoschnicke
requested changes
Oct 22, 2020
Contributor
SKoschnicke
left a comment
SKoschnicke
left a comment
There was a problem hiding this comment.
I think the following methods can be removed as they are private and not called in the class:
- getAllPossibleMoves
- getPossibleStartMoves
- getAllMoves
Everthing else looks good to me!
Member
|
Wieder so ein PR wo squashen einen unnötig großen commit erzeugt... Ich glaube ich muss die convention anpassen, ich bin andere arbeitsstile gewohnt ^^ |
Contributor
Author
|
Es sind ein paar kleine Änderungen und ein großer Commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shall resolve #301