Fix human valid piece calculation #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enableWhen applied to the whole "sochaIcon"-menu due to its scope
Should fix #43 Since we do not have sufficient automated testing yet, I can only assume it to be fixed through experimentation and understanding of the code.
SKoschnicke
approved these changes
Jan 25, 2021
Contributor
SKoschnicke
left a comment
SKoschnicke
left a comment
There was a problem hiding this comment.
Looks better, but have to test with new backend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #43
Since we do not have sufficient automated testing yet, I can only assume it to be fixed through experimentation and understanding of the code.
Includes some extra improvements