feat(view): unify skip-button with play button#63
Merged
Conversation
anarchuser
approved these changes
Jan 25, 2021
SKoschnicke
approved these changes
Jan 25, 2021
Contributor
SKoschnicke
left a comment
SKoschnicke
left a comment
There was a problem hiding this comment.
Skip works, but the overall state of the button and the GUI seems still buggy (might be because of issues with the backend). I will test that again with the new backend.
Member
Author
|
yes, the button definitely still needs some love - e.g. when playing as a human, there is no need to "pause" while the computer is playing - the skip button should simply be shortly disabled in that case |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #50