refactor: use bindings in GameController #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SKoschnicke
reviewed
Jan 28, 2021
Contributor
SKoschnicke
left a comment
SKoschnicke
left a comment
There was a problem hiding this comment.
Nice improvements code-wise!
But I also got something like a stack overflow on creating a new game (after playing the first one) which opened many windows (probably with a JavaFX error/stack trace).
xeruf
force-pushed
the
refactor/bindings
branch
from
180c338 to
da0f516
Compare
Member
Author
|
Seems working now, fixing the issue :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works for me, but needs more elaborate testing. I once had a Stackoverflow from an infinite loop after closing after a game.
Fix #43