penguins: resolve NoneType error for get_most_fish #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith occupied fields
maxblan
changed the title
Collaborator
|
Hi, thank you for your contribution. I have checked the problem and your PR is accepted. |
maxblan
added a commit
that referenced
this pull request
Dec 20, 2022
* field: add a repr method * readme: remove shield with error * cartesiancoordinate: raise a index error now * test: add tests for the board class * fixed bug to prevent type error when calling get_most_fish on board with occupied fields (#19) Co-authored-by: Daniel <daniel.klingebiel@gmail.com> * release v1.0.0 * test: fix bug in a board test Co-authored-by: tms-hl <100803511+tms-hl@users.noreply.github.com> Co-authored-by: Daniel <daniel.klingebiel@gmail.com>
maxblan
added a commit
that referenced
this pull request
Dec 23, 2022
* field: add a repr method * readme: remove shield with error * cartesiancoordinate: raise a index error now * test: add tests for the board class * fixed bug to prevent type error when calling get_most_fish on board with occupied fields (#19) Co-authored-by: Daniel <daniel.klingebiel@gmail.com> * release v1.0.0 * test: fix bug in a board test Co-authored-by: tms-hl <100803511+tms-hl@users.noreply.github.com> Co-authored-by: Daniel <daniel.klingebiel@gmail.com> (cherry picked from commit f910d21)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves a bug that causes "TypeError: '<' not supported between instances of 'NoneType' and 'int'"
The field list is sorted using get_fish(). get_fish returns None if the field is occupied.
Because of this occupied fields have to be filtered before trying to sort the list.