Skip to content

penguins: resolve NoneType error for get_most_fish #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2022
Merged

penguins: resolve NoneType error for get_most_fish #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion socha/api/plugin/penguins.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,7 +671,8 @@ def get_most_fish(self) -> List[Field]:

:return: A list of Fields.
"""
fields = self.get_all_fields()

fields = list(filter(lambda field_x: not field_x.is_occupied(), self.get_all_fields()))
fields.sort(key=lambda field_x: field_x.get_fish(), reverse=True)
for i, field in enumerate(fields):
if field.get_fish() < fields[0].get_fish():
Expand Down