Skip to content

Conversation

@YoEnte
Copy link
Collaborator

@YoEnte YoEnte commented Jan 16, 2025

Description

I noticed that the Server accepts python 310 and 312, but the bot auto-build is only for 310.
So I added a feature (logic.py launch parameter) to specify the python version, the standard value still is 3.10.
Then I updated the readme to accommodate the new parameter and updated it at some other parts in the bot building section.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

23 or more test exports, which got checked by the server testing tool

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
    • no huge changes, only copy-paste, should be self-explainatory
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
    • not needed at this point, they are not even tests for the existing parameters ;)

@YoEnte
Copy link
Collaborator Author

YoEnte commented Jan 16, 2025

Ehhmm... The Table of Content change in the readme must have happend automatically, I cannot remember doing that ._.
But I guess thats alright

@maxblan maxblan closed this Jan 17, 2025
@maxblan maxblan reopened this Jan 17, 2025
@maxblan maxblan merged commit da95965 into master Jan 17, 2025
1 check passed
@YoEnte YoEnte deleted the add-build-py-version branch August 12, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants