Skip to content

Add info to the remaining node inspector sections#969

Merged
srzeszut merged 3 commits intomainfrom
805-consider-renaming-callback-tracing
Apr 13, 2026
Merged

Add info to the remaining node inspector sections#969
srzeszut merged 3 commits intomainfrom
805-consider-renaming-callback-tracing

Conversation

@srzeszut
Copy link
Copy Markdown
Contributor

@srzeszut srzeszut commented Apr 9, 2026

No description provided.

@srzeszut srzeszut linked an issue Apr 9, 2026 that may be closed by this pull request
@srzeszut srzeszut requested a review from Copilot April 9, 2026 11:13
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds info tooltips to the remaining node inspector sections by introducing a generic section_info_tooltip component and integrating it into the section headers. The changes consolidate tooltip functionality across multiple sections (Streams, Async Jobs, and Callback Traces) by replacing a section-specific tooltip with a reusable generic component.

Changes:

  • Added title_sub_panel slot to the collapsible_section component to support displaying content next to section titles
  • Created a new generic section_info_tooltip component that displays an info icon with a configurable tooltip
  • Removed the section-specific streams_info_tooltip component and replaced it with the generic component
  • Updated the Streams, Async Jobs, and Callback Traces sections to use the new section_info_tooltip component with appropriate help text
  • Added title_class styling attribute to sections to properly space the title and tooltip together

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
lib/live_debugger/app/web/components.ex Added title_sub_panel slot to collapsible_section and created new generic section_info_tooltip component
lib/live_debugger/app/debugger/streams/web/components.ex Removed section-specific streams_info_tooltip and updated to use new generic component via title_sub_panel slot
lib/live_debugger/app/debugger/callback_tracing/web/node_traces_live.ex Added info tooltip to Callback Traces section using new generic component
lib/live_debugger/app/debugger/async_jobs/web/async_jobs_live.ex Added info tooltip to Async Jobs section using new generic component

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lib/live_debugger/app/web/components.ex Outdated
@srzeszut srzeszut marked this pull request as ready for review April 9, 2026 11:30
@srzeszut srzeszut requested review from hhubert6 and kraleppa April 9, 2026 17:27
Copy link
Copy Markdown
Contributor

@hhubert6 hhubert6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can move info icon of temporary assigns to the left as well

@srzeszut srzeszut merged commit 2365db4 into main Apr 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider renaming "callback tracing"

4 participants