Thread pool #712
Merged
Thread pool #712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poneciak57
requested review from
Copilot,
maciejmakowski2003,
mdydek,
michalsek and
vltkv
Contributor
There was a problem hiding this comment.
Pull Request Overview
Introduces a lock-free single-producer thread pool and integrates it into PromiseVendor to offload asynchronous promise work from ad-hoc std::thread creation.
- Adds ThreadPool with load balancer and worker threads using SPSC channels.
- Replaces per-promise detached thread creation with pooled task scheduling.
- Adds configurable constants for thread pool sizing.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| audioapi/utils/ThreadPool.hpp | New thread pool implementation (load balancer + worker queues). |
| audioapi/jsi/JsiPromise.h | Integrates a shared ThreadPool into PromiseVendor. |
| audioapi/jsi/JsiPromise.cpp | Uses ThreadPool->schedule instead of spawning detached threads. |
| audioapi/core/utils/Constants.h | Adds sizing constants for the thread pool. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/react-native-audio-api/common/cpp/audioapi/utils/ThreadPool.hpp
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/utils/ThreadPool.hpp
Outdated
Show resolved
Hide resolved
maciejmakowski2003
approved these changes
Oct 3, 2025
Collaborator
|
LGTM |
michalsek
reviewed
Oct 3, 2025
packages/react-native-audio-api/common/cpp/audioapi/utils/ThreadPool.hpp
Outdated
Show resolved
Hide resolved
michalsek
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RNAA-263
Closes RNAA-259
Implemented simple thread pool which allows for blazingly fast task dispatch. It has some limitations and allow dispatch only from one thread. It is not thread safe. To make it safer while mantaining the speed multi-producer multi-consumer queue/channel would be required. But for now it seems sufficient cuz we want to mostly offload audio thread and still we can create multiple PromiseVendors.
Introduced changes
Checklist