Skip to content

Conversation

@szydlovsky
Copy link
Collaborator

@szydlovsky szydlovsky commented Nov 27, 2025

Summary

Fixes: #287.
One of previous PRs has introduced a regression in the logic behind removing all the characters from a line.
When it happens, iOS applies attributes from the previous line.
It's especially bad when paragraph styles are in the line before and a bullet point suddenly appears.

The original fix was to manually remove the characters, remove typing attributes and for the paragraph styles reapply the style that was there in the current line.
Some PR must have removed the typing attributes/style reapplying part when working with that code so I'm returning it to the properly working state.

Test Plan

Scenario 1:
Write one line with some paragraph style.
Then another line with no styling and remove all the characters from the second line.
The paragraph style from the first line shouldn't expand to the second line.

Scenario 2:
Write one line with some paragraph style.
Then another line with a different paragraph style and remove all the characters from the second line.
The style should still be there but with an empty line and the style from first paragraph shouldn't take over the second line's styling.

Screenshots / Videos

Before

Screen.Recording.2025-11-27.at.19.17.05.mov

After

Screen.Recording.2025-11-27.at.19.58.31.mov

Compatibility

OS Implemented
iOS
Android

Copy link
Collaborator

@kacperzolkiewski kacperzolkiewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 🚀

@szydlovsky szydlovsky merged commit f5ed26e into main Nov 28, 2025
5 checks passed
@szydlovsky szydlovsky deleted the @szydlovsky/ios-paragraphs-typing-attributes-fix branch November 28, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[IOS] List styles from the previous line are applied for another list when press backspace

3 participants