fix(iOS): remove unnecessary spaces during html preparation #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exploIF
approved these changes
Dec 17, 2025
Collaborator
exploIF
left a comment
exploIF
left a comment
There was a problem hiding this comment.
Functionally works well. I think it's worth checking if we can create tags set programmatically, but this can be handled in separate PR
szydlovsky
reviewed
Dec 17, 2025
Collaborator
szydlovsky
left a comment
szydlovsky
left a comment
There was a problem hiding this comment.
Overally good, some smaller changes and we're good to go
szydlovsky
approved these changes
Dec 17, 2025
szydlovsky
reviewed
Dec 17, 2025
Co-authored-by: Mikołaj Szydłowski <9szydlowski9@gmail.com>
kacperzolkiewski
deleted the
@kacperzolkiewski/fix-parsing-html-with-spaces
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #290
This PR adds functionality for removing unnecessary whitespaces that breaks our html parsing.
Test Plan
Run test case from issue: #290
Screenshots / Videos
Screen.Recording.2025-12-11.at.15.20.19.mov
Screen.Recording.2025-12-11.at.15.22.40.mov
Compatibility