test(native): unify model URLs on v0.9.0 + fix ssdlite shape assertion#1185
Merged
Conversation
run_tests.sh: bumped every MODELS entry to its canonical v0.9.0 path from src/constants/modelUrls.ts; mixed v0.6/0.7/0.8/main URLs caused the runner to pull artifacts that no longer matched what the JS API ships. ObjectDetectionTest.cpp: the v0.9.0 ssdlite is exported without a leading batch dim, so GetInputShapeWorks now asserts (C, H, W) instead of (1, C, H, W).
msluszniak
added
the
test
chmjkb
reviewed
May 25, 2026
Hoists the v0.9.0 version tag into a single LIB_VERSION variable + HF_VERSION_TAG derived constant, so future bumps are one-line changes.
chmjkb
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The native test runner downloaded model artifacts from a mix of
main,v0.6.0,v0.7.0,v0.8.0, andv0.9.0HuggingFace paths, none of which lined up with whatsrc/constants/modelUrls.tsactually ships on v0.9.0. This PR points everyMODELSentry inrun_tests.shat its canonical v0.9.0 path (verified with HEAD checks), keeping the destination filenames identical so the integration.cppconstants don't need to move.The v0.9.0 SSDLite is exported without a leading batch dim, so
ObjectDetectionInheritedTests.GetInputShapeWorksnow asserts rank-3(C, H, W)instead of rank-4(1, C, H, W).Introduces a breaking change?
Type of change
Tested on
Testing instructions
cd packages/react-native-executorch/common/rnexecutorch/tests bash ./run_tests.sh --refresh-models--refresh-modelsis required on first run since every URL changed; cached files from older versions are stale. All 23 test suites pass on a physical Android device.Screenshots
Related issues
Checklist
Additional notes