Skip to content

[RNE Rewrite] feat: add instance segmentation pipeline#1289

Merged
msluszniak merged 10 commits into
rne-rewritefrom
@bh/add-instance-segmentation
Jun 29, 2026
Merged

[RNE Rewrite] feat: add instance segmentation pipeline#1289
msluszniak merged 10 commits into
rne-rewritefrom
@bh/add-instance-segmentation

Conversation

@barhanc

@barhanc barhanc commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Adds instance segmentation task pipeline and corresponding example screen in computer-vision app.

Introduces a breaking change?

  • Yes
  • No

Type of change

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Documentation update (improves or adds clarity to existing documentation)
  • Other (chores, tests, code style improvements etc.)

Tested on

  • iOS
  • Android

Testing instructions

Screenshots

Related issues

Closes #1238

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings

Additional notes

Can be merged only after #1287

@barhanc barhanc self-assigned this Jun 26, 2026
@barhanc barhanc added feature PRs that implement a new feature refactoring labels Jun 26, 2026
@barhanc barhanc linked an issue Jun 26, 2026 that may be closed by this pull request
[RNE Rewrite] CV - add instance segmentation pipeline implementation #1238
Closed
@barhanc barhanc added blocked Issue blocked by some problems (but not other issue, use relationship -> blocker instead) and removed blocked Issue blocked by some problems (but not other issue, use relationship -> blocker instead) labels Jun 26, 2026
@barhanc barhanc force-pushed the @bh/add-instance-segmentation branch from 570023a to b0d203d Compare June 29, 2026 11:39
msluszniak
msluszniak reviewed Jun 29, 2026
View reviewed changes
Comment thread packages/react-native-executorch/cpp/extensions/cv/box_ops.cpp Outdated
Comment thread packages/react-native-executorch/src/extensions/cv/tasks/instanceSegmentation.ts
msluszniak
msluszniak reviewed Jun 29, 2026
View reviewed changes
Comment thread packages/react-native-executorch/src/extensions/cv/ops/image.ts Outdated
Comment thread packages/react-native-executorch/cpp/extensions/cv/box_ops.cpp Outdated
Comment thread packages/react-native-executorch/src/extensions/cv/tasks/instanceSegmentation.ts
Comment thread packages/react-native-executorch/src/extensions/cv/tasks/instanceSegmentation.ts Outdated
Comment thread packages/react-native-executorch/cpp/extensions/cv/box_ops.cpp Outdated
Comment thread packages/react-native-executorch/cpp/extensions/cv/box_ops.cpp Outdated
@barhanc barhanc marked this pull request as ready for review June 29, 2026 13:00
@barhanc barhanc requested a review from msluszniak June 29, 2026 13:43
msluszniak
msluszniak approved these changes Jun 29, 2026
View reviewed changes

@msluszniak msluszniak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Demo app works correctly

@msluszniak msluszniak merged commit c5d5f7f into rne-rewrite Jun 29, 2026
2 checks passed
@msluszniak msluszniak deleted the @bh/add-instance-segmentation branch June 29, 2026 14:52
msluszniak added a commit that referenced this pull request Jun 29, 2026
@msluszniak
chore(computer-vision): add objectDetection + instanceSegmentation fe…
ca8a349 
…atures

The demo app now has detection (#1284) and instance-segmentation (#1289)
screens (useObjectDetector / useInstanceSegmenter); declare them so the
feature list matches the hooks the app actually uses.
msluszniak added a commit that referenced this pull request Jun 29, 2026
@msluszniak
[RNE Rewrite] chore: fix clang-tidy findings in restrictToBox/threshold
aa0d60c 
These CV/math functions landed via the instance-segmentation pipeline (#1289)
after the per-group passes, so the rebase onto rne-rewrite surfaced findings the
groups had not yet seen. Apply the same idioms used elsewhere:

- const auto *name for the JSI function-name locals (llvm-qualified-auto)
- value-initialize the parse-result locals boxFormat / cvType (init-variables)
- use auto for the cast-initialized x1/y1/x2/y2 and thresholdVal (use-auto)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msluszniak msluszniak msluszniak approved these changes

Assignees

@barhanc barhanc

Labels

feature PRs that implement a new feature refactoring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RNE Rewrite] CV - add instance segmentation pipeline implementation

2 participants

@barhanc @msluszniak