Skip to content

Conversation

@NorbertKlockiewicz
Copy link
Contributor

@NorbertKlockiewicz NorbertKlockiewicz commented May 23, 2025

Description

This PR introduces new structure of repository:

  • apps directory - contains standalone applications which are using package from packages directory
  • packages - contains react native executorch library

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improves or adds clarity to existing documentation)

Tested on

  • iOS
  • Android

Testing instructions

Screenshots

Related issues

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings

Additional notes

@NorbertKlockiewicz NorbertKlockiewicz linked an issue May 23, 2025 that may be closed by this pull request
3 tasks
@NorbertKlockiewicz NorbertKlockiewicz linked an issue May 23, 2025 that may be closed by this pull request
@NorbertKlockiewicz NorbertKlockiewicz self-assigned this May 23, 2025
@NorbertKlockiewicz NorbertKlockiewicz linked an issue May 23, 2025 that may be closed by this pull request
3 tasks
Copy link
Contributor

@jakmro jakmro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

Copy link
Contributor

@pweglik pweglik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nitpicks and clarifications in configs

@pweglik pweglik self-requested a review May 26, 2025 13:39
Copy link
Contributor

@pweglik pweglik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now 👍 Before merging, please make sure we pass linting on all of the code and all of example apps build

@NorbertKlockiewicz NorbertKlockiewicz merged commit ae7188a into main May 27, 2025
4 checks passed
@NorbertKlockiewicz NorbertKlockiewicz deleted the @nk/monorepo-setup branch May 27, 2025 08:40
msluszniak pushed a commit to MateWW/react-native-executorch that referenced this pull request May 28, 2025
## Description

This PR introduces new structure of repository:
- apps directory - contains standalone applications which are using
package from `packages` directory
- packages - contains react native executorch library
### Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Documentation update (improves or adds clarity to existing
documentation)

### Tested on

- [x] iOS
- [x] Android

### Testing instructions

<!-- Provide step-by-step instructions on how to test your changes.
Include setup details if necessary. -->

### Screenshots

<!-- Add screenshots here, if applicable -->

### Related issues

<!-- Link related issues here using #issue-number -->

### Checklist

- [ ] I have performed a self-review of my code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have updated the documentation accordingly
- [ ] My changes generate no new warnings

### Additional notes

<!-- Include any additional information, assumptions, or context that
reviewers might need to understand this PR. -->

---------

Co-authored-by: pweglik <36445788+pweglik@users.noreply.github.com>
mkopcins pushed a commit that referenced this pull request Oct 15, 2025
## Description

This PR introduces new structure of repository:
- apps directory - contains standalone applications which are using
package from `packages` directory
- packages - contains react native executorch library
### Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Documentation update (improves or adds clarity to existing
documentation)

### Tested on

- [x] iOS
- [x] Android

### Testing instructions

<!-- Provide step-by-step instructions on how to test your changes.
Include setup details if necessary. -->

### Screenshots

<!-- Add screenshots here, if applicable -->

### Related issues

<!-- Link related issues here using #issue-number -->

### Checklist

- [ ] I have performed a self-review of my code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have updated the documentation accordingly
- [ ] My changes generate no new warnings

### Additional notes

<!-- Include any additional information, assumptions, or context that
reviewers might need to understand this PR. -->

---------

Co-authored-by: pweglik <36445788+pweglik@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build demo apps with a package built from workspace

4 participants