Skip to content

Remove react-native-live-audio-strem dependency from the library.#343

Merged
pweglik merged 1 commit intomainfrom
@pw/chore-remove-dep
May 27, 2025
Merged

Remove react-native-live-audio-strem dependency from the library.#343
pweglik merged 1 commit intomainfrom
@pw/chore-remove-dep

Conversation

@pweglik
Copy link
Copy Markdown
Contributor

@pweglik pweglik commented May 27, 2025

Description

We don't use it anywhere in the library - artifact of the past.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improves or adds clarity to existing documentation)

Tested on

  • iOS
  • Android

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings

@pweglik pweglik requested a review from mkopcins May 27, 2025 12:20
@pweglik pweglik self-assigned this May 27, 2025
@pweglik pweglik merged commit 6f684c1 into main May 27, 2025
2 checks passed
@pweglik pweglik deleted the @pw/chore-remove-dep branch May 27, 2025 13:50
msluszniak pushed a commit to MateWW/react-native-executorch that referenced this pull request May 28, 2025
software-mansion#343)

## Description

We don't use it anywhere in the library - artifact of the past.

### Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Documentation update (improves or adds clarity to existing
documentation)

### Tested on

- [x] iOS
- [ ] Android


### Checklist

- [x] I have performed a self-review of my code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have updated the documentation accordingly
- [x] My changes generate no new warnings
mkopcins pushed a commit that referenced this pull request Jun 5, 2025
#343)

We don't use it anywhere in the library - artifact of the past.

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Documentation update (improves or adds clarity to existing
documentation)

- [x] iOS
- [ ] Android

- [x] I have performed a self-review of my code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have updated the documentation accordingly
- [x] My changes generate no new warnings
mkopcins pushed a commit that referenced this pull request Oct 15, 2025
#343)

## Description

We don't use it anywhere in the library - artifact of the past.

### Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Documentation update (improves or adds clarity to existing
documentation)

### Tested on

- [x] iOS
- [ ] Android


### Checklist

- [x] I have performed a self-review of my code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have updated the documentation accordingly
- [x] My changes generate no new warnings
mkopcins pushed a commit that referenced this pull request Oct 15, 2025
#343)

We don't use it anywhere in the library - artifact of the past.

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Documentation update (improves or adds clarity to existing
documentation)

- [x] iOS
- [ ] Android

- [x] I have performed a self-review of my code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have updated the documentation accordingly
- [x] My changes generate no new warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants