Refactor monorepo's package.json
#377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msluszniak
changed the title
package.json
Member
Author
|
I need to downgrade typescript here to version |
pweglik
reviewed
Jun 9, 2025
Contributor
|
Hey, I don't think it's neccessary, we're working on removing dependecy from Scroll picker anyway, and it's really weird choice of them to put typescript in peer dependencies. This way we don't have to maintain typescript version in every package.json - after your changes we'd need to do that |
Member
Author
|
Ok, So I think that it would be reasonable to keep only change from |
Contributor
|
Yeah, let's do it - we already track scroll piker change with this issue so no need to create another one: #224 that @mlodyjesienin takes care of right now |
msluszniak
changed the title
package.jsonpackage.json
pweglik
approved these changes
Jun 10, 2025
mkopcins
pushed a commit
that referenced
this pull request
Oct 15, 2025
## Description This PR removes warnings while installing dependencies using `yarn`. Before this change there were some warnings about `typescript` dependency: ``` ➤ YN0000: · Yarn 4.1.1 ➤ YN0000: ┌ Project validation ➤ YN0057: │ react-native-executorch: Resolutions field will be ignored ➤ YN0000: └ Completed ➤ YN0000: ┌ Resolution step ➤ YN0000: └ Completed in 0s 504ms ➤ YN0000: ┌ Post-resolution validation ➤ YN0002: │ computer-vision@workspace:apps/computer-vision doesn't provide typescript (pe8761), requested by react-native-wheel-scrollview-picker. ➤ YN0002: │ speech-to-text@workspace:apps/speech-to-text doesn't provide typescript (pf5fda), requested by react-native-wheel-scrollview-picker. ➤ YN0086: │ Some peer dependencies are incorrectly met; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code. ➤ YN0000: └ Completed ➤ YN0000: ┌ Fetch step ➤ YN0000: └ Completed in 0s 502ms ➤ YN0000: ┌ Link step ➤ YN0000: └ Completed in 0s 239ms ➤ YN0000: · Done with warnings in 1s 341ms ``` after the change, it looks like this: ``` ➤ YN0000: · Yarn 4.1.1 ➤ YN0000: ┌ Project validation ➤ YN0057: │ llm: Resolutions field will be ignored ➤ YN0057: │ react-native-executorch: Resolutions field will be ignored ➤ YN0000: └ Completed ➤ YN0000: ┌ Resolution step ➤ YN0000: └ Completed ➤ YN0000: ┌ Fetch step ➤ YN0000: └ Completed in 0s 383ms ➤ YN0000: ┌ Link step ➤ YN0000: └ Completed in 0s 239ms ``` Apart from that, I change monorepo `package.json` to include all example apps from `apps` directory all in one. ### Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation update (improves or adds clarity to existing documentation) ### Tested on - [x] iOS - [x] Android ### Testing instructions <!-- Provide step-by-step instructions on how to test your changes. Include setup details if necessary. --> ### Screenshots <!-- Add screenshots here, if applicable --> ### Related issues <!-- Link related issues here using #issue-number --> ### Checklist - [x] I have performed a self-review of my code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have updated the documentation accordingly - [x] My changes generate no new warnings ### Additional notes <!-- Include any additional information, assumptions, or context that reviewers might need to understand this PR. --> --------- Co-authored-by: Mateusz Sluszniak <sluszmat@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes warnings while installing dependencies using
yarn. Before this change there were some warnings abouttypescriptdependency:after the change, it looks like this:
Apart from that, I change monorepo
package.jsonto include all example apps fromappsdirectory all in one.Type of change
Tested on
Testing instructions
Screenshots
Related issues
Checklist
Additional notes