feat: Flag for mean pooling text embeddings#384
Merged
Conversation
msluszniak
reviewed
Jun 10, 2025
msluszniak
reviewed
Jun 10, 2025
pweglik
force-pushed
the
@pw/flag-for-mean-pooling-text-embeddings
branch
from
574a8a6 to
6e811f2
Compare
mkopcins
approved these changes
Jun 12, 2025
pweglik
force-pushed
the
@pw/flag-for-mean-pooling-text-embeddings
branch
from
631702a to
7cc94c6
Compare
mkopcins
pushed a commit
that referenced
this pull request
Oct 15, 2025
## Description Some models do mean pooling, some don't. We can set flag to take that into account - we should set this flag in all presets for our models while completing: #359 ### Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation update (improves or adds clarity to existing documentation) ### Tested on - [x] iOS - [x] Android ### Related issues #353 ### Checklist - [x] I have performed a self-review of my code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have updated the documentation accordingly - [ ] My changes generate no new warnings **They actually do, if users don't set the flag** ### Additional notes <!-- Include any additional information, assumptions, or context that reviewers might need to understand this PR. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some models do mean pooling, some don't. We can set flag to take that into account - we should set this flag in all presets for our models while completing: #359
Type of change
Tested on
Related issues
#353
Checklist
Additional notes