Skip to content

feat: Simplify s2t app#491

Merged
jakmro merged 6 commits intomainfrom
@jakmro/simplify-s2t-app
Aug 11, 2025
Merged

feat: Simplify s2t app#491
jakmro merged 6 commits intomainfrom
@jakmro/simplify-s2t-app

Conversation

@jakmro
Copy link
Copy Markdown
Contributor

@jakmro jakmro commented Aug 7, 2025

Description

Changes:

  • Simplify s2t example app
  • use react-native-audio-api to collect live audio for live streaming transcription

Introduces a breaking change?

  • Yes
  • No

Type of change

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Documentation update (improves or adds clarity to existing documentation)
  • Other (chores, tests, code style improvements etc.)

Tested on

  • iOS
  • Android

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings

@jakmro jakmro added this to the v0.5.0 milestone Aug 7, 2025
@jakmro jakmro requested review from chmjkb and mkopcins August 7, 2025 13:46
@jakmro jakmro self-assigned this Aug 7, 2025
@jakmro jakmro added documentation Improvements or additions to documentation enhancement labels Aug 7, 2025
@jakmro jakmro changed the title @jakmro/simplify s2t app feat: Simplify s2t app Aug 7, 2025
@msluszniak
Copy link
Copy Markdown
Member

Probably closes this one: #230

@jakmro jakmro linked an issue Aug 7, 2025 that may be closed by this pull request
@msluszniak
Copy link
Copy Markdown
Member

msluszniak commented Aug 7, 2025

Few things from my side:

image
  • Once I tried to use Start Live Transcription it either crashed the whole app or caused the following error:
image

I consider it a regression since the previous version had this button explicitly disabled on emulators.

  • The text in the input box for URL states: "Audio File URL to transcribe". This however, expects not a random audio file to transcribe but specifically mp3 format. Change this text to one that will clearly indicate this fact and then I believe this will be completely sufficient to close the issue: Implement guard in Speech to text demo app which filters wrong input formats #409. Implementing guard for mp3 files in the example is a bit of an overkill and clear information will be absolutely fine.

@msluszniak
Copy link
Copy Markdown
Member

msluszniak commented Aug 7, 2025

FYI, this PR also solves this issue: #471 as I was able to successfully submit more then one url to transcription :))

@jakmro jakmro linked an issue Aug 8, 2025 that may be closed by this pull request
@chmjkb
Copy link
Copy Markdown
Collaborator

chmjkb commented Aug 11, 2025

fyi @msluszniak, the token you mentioned is a timestamp :D

Comment on lines +96 to +97
const buffor = buffer.getChannelData(0);
const bufforArray = Array.from(buffor);
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename those? the naming looks off

@jakmro jakmro requested a review from chmjkb August 11, 2025 08:27
@jakmro jakmro merged commit d6c8fa0 into main Aug 11, 2025
3 checks passed
@jakmro jakmro deleted the @jakmro/simplify-s2t-app branch August 11, 2025 08:43
mkopcins pushed a commit that referenced this pull request Oct 15, 2025
## Description

Changes:
- Simplify s2t example app
- use `react-native-audio-api` to collect live audio for live streaming
transcription

### Introduces a breaking change?

- [ ] Yes
- [x] No

### Type of change

- [ ] Bug fix (change which fixes an issue)
- [ ] New feature (change which adds functionality)
- [x] Documentation update (improves or adds clarity to existing
documentation)
- [x] Other (chores, tests, code style improvements etc.)

### Tested on

- [x] iOS
- [x] Android

### Checklist

- [x] I have performed a self-review of my code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [x] I have updated the documentation accordingly
- [x] My changes generate no new warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

3 participants